FIXED: Bug in severity of Logger's internal Error DAT

Bugs
1

Hello,
I have noticed there is a little problem with Error DAT inside of Logger component. Its severity parameter is set using following expression:

'*' if parent().par.Loglevel == 'INFO' else 'warning abort' if parent().par.Loglevel == 'WARNING' else 'abort'

This produces incorrect severity value (abort) when DEBUG log level is set on Logger. I guess it should instead produce severity value of warning error (maybe also fatal but it is not present in any other log level so I guess this is skipped).


This is unrelated to bug in severity parameter, but I am wondering why is following exclusion hardcoded into the error1_callbacks?

if parent.Logger.par.Active and 'Cook dependency loop detected' not in message:
    ...

I would like to use new Logger also for catching TD warnings and errors - it seems like a great way to see every important message in one place (surely it needs some cleanup to remove messages repeating on every frame, but I guess that could be done). Cook dependency warnings could be helpful in log, so I am a little confused why are these excluded.

2

Hey @monty_python

Thanks for the report.

It is logged for it to be looked into.

If I’m being honest I don’t quite recall what pushed me to exclude the cook dependency warnings. Could be because of some spamming or something :sweat_smile:

I’ll try to figure it out.

Thanks,
Michel

4

No problem, I recall there were quite a lot of these warnings originating from internal TD components some time ago. Maybe that was flooding the log :slight_smile:

6

Hi @monty_python

Will be fixed in 2023.30k.

For Logger Level=
Debug, Info => *
Warning => warning, abort
Error, Critical => abort

I removed the filtering of cook dep loops

best,
Michel

1 Like
7

Great, thanks

1 Like