System::
2023 M2 Ultra Mac Studio
128GB Ram
MacOS 13.5 (22G74)
Issue::
When Loop Crossfade is enabled, the Movie File In TOP’s cook time will consistently grow during crossfade periods. If you’re playing back multiple high res videos with TOPs that have crossfade, this happens for every Move File In TOP so the issue stacks and you’ll lose 60FPS quite quickly.
From my testing, I’ve tried with 1080p, 2k, 3k, and 4k HAP playback, this happens consistently, 100% of the time for any Movie File In TOP with crossfade enabled. Note I’m not seeing growing cook time for the movie file in TOPs with zero crossfade, so it seems strictly tied to crossfaded loops. Enabling/disabling interpolation has no impact on outcome (will grow every loop either way)
Attaching a trail showing the growing cook time (you can easily reproduce with a single movie TOP with crossfade as long as you’re using a codec that can keep up, will be more pronounced with high res videos). Also attaching my config of the movie TOP
There’s definitely also a memory leak alongside the increasing cook time
Dropping pre-read and timeout do not resolve
If I disable the crossfade I’ll see cook time come back down and settle to a stable state, but you can see memory still leaking
Captured some better data by getting a running avg for cook against CPU mem usage. (Note I also checked GPU mem, read ahead misses, and a few others, no discernible trendlines with them, seem normal)
I’m actually not able to reproduce this as you show it. The cook time spikes themselves seem fine offhand, Loop Crossfade does more than 2x the amount of work, so the node should take more than 2x as long to cook during a crossfade. I wouldn’t expect the times to climb like you are showing though. Are you able to share your example .toe file and possibly your content.
The other things to keep in mind is that the cpu_mem_usage channel on macOS is the amount of memory resident currently, not the amount used by the process as a whole. Memory can be paged in/out freely by the OS, and I can’t seem to find a good way to get the ‘total memory usage’ of the process. If you use the Activity Monitor though, do you see the ‘Memory’ column growing in your tests?
Noted on memory, I’ll give a more detailed look tomorrow and let you know.
Here’s a link to a ZIP with the TOE from above and a sample HAP video (also confirmed I’m seeing the cook time increase with this exact TOE+video) https://www.dropbox.com/t/CQ1PYZsx0gIVL898
Also including just the TOE here for anyone that doesn’t want to download the larger HAP video moviefilein_leak.toe (4.0 KB)
Was able to do a better test for memory usage. This is tracking real memory usage based on unique set size for the process (+ subprocesses) over a 10min period. Using the sample TOE+video I attached above.
Looks like it may be leaking ~150MB over that 10min period. There may be something to what you’re saying in terms of how the OS is handling allocations but it definitely feels like either way there are some unnecessary allocations happening somewhere in the video playback logic (independent of crossfade). I haven’t been low level in MacOS in a long time though so it’s certainly possible I’m overlooking something OS side.
